Fix: Show the author and author name examples in the Stylebook #69436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
added
[Block] Post Author
|
Size Change: +9 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP 6.8 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.8 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Mar 5, 2025
Co-authored-by: carolinan <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: im3dabasia <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: f4039e8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The title of this PR is a bit misguiding because the code change is unrelated to the Stylebook.
But the expected result is for the post author and post author name blocks to show in the Stylebook.
Closes #68513
Why?
#67136 Added a bug fix to the two blocks, which meant that if the post type did not support the post author, there would be a notice displayed in the editor to inform the user.
This also lead to the notice showing when the post type is
undefined. And the post type isundefinedwhen you view the Stylebook.There are exceptions where the post type is not undefined, and that is when editing a template for the single post or single page, and then opening the stylebook from within the Site Editor. But in these cases, the blocks already show their examples correctly.
I have made this code change based on the following:
Testing Instructions
With any theme type: Confirm that there are no regressions when inserting a post author block when editing content, either post, page, or custom post type.
Classic theme:
Activate a classic theme that has support for the stylebook. For example, Twenty Fifteen.
Open Appearance > Design > Styles and look for the author and author name blocks.
Confirm if the block shows with a basic example and not a message saying that the block is unsupported.
Block theme:
Activate a block theme, and test the stylebook in two places:
In the Site Editor, when editing different type of templates. -Open the Styles sidebar and open the Stylebook.
Look for the author and author name blocks.
Confirm if the block shows with a basic example and not a message saying that the block is unsupported.
Open the first screen of the Site Editor and choose Styles in the sidebar.
Open the Stylebook.
Open the blocks panel.
Look for the author and author name blocks.
Confirm if the block shows with a basic example and not a message saying that the block is unsupported.
Screenshots or screencast